ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Fix typos in code and comments + some reformatting

Browse Source 
Change-Id: Ic6fe197734655a2591a6730d07f23d4222a278f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210564
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Andrea Gelmini
2026-09-10 22:06:44 +02:00
committed by Julien Nabet
parent f1c58464ac
commit be7ff6a857
20 changed files with 39 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli_ure/source/basetypes/uno/PolymorphicType.cs
+5 -5
View File
@@ -28,14 +28,14 @@ namespace uno {
/** represents a polymorphic type.
This class is used to carry type information for polymorphic struct types
and arrays of polymorphic struct types. These types would be easiest represented
and arrays of polymorphic struct types. These types would be most easily represented
with type templates, which are not available in .NET 1.1. Therefore
the System.Type cannot contain information about template parameters. To
retain this information we use PolymorphicType which directly inherits from
System.Type. The additional information about type parameters are passed
as simple string when creating an instance of PolymorphicType. Usually one
as a simple string when creating an instance of PolymorphicType. Usually one
only needs a PolymorphicType when a polymorphic type is put into an
uno.Any. For example, let's assume there is a idl type PolyStruct:
uno.Any. For example, let's assume there is an idl type PolyStruct:
module test {
struct PolyStruct< T >
@@ -90,7 +90,7 @@ public class PolymorphicType: Type
/** provides a unique instance of this class.
This function returns null if the specified type is no polymorphic struct.
This function returns null if the specified type is not a polymorphic struct.
@param type
the type of the polymorphic struct. For example, created by
@@ -98,7 +98,7 @@ public class PolymorphicType: Type
@param name
the full name of the struct (including the type list).
@return
null - the argument type is no valid polymorphic struct or <br>
null - the argument type is not a valid polymorphic struct or <br>
an instance of this class.
@exception System.ArgumentNullException
The argument was null.
compilerplugins/clang/conditionalstring.cxx
+2 -4
View File
@@ -17,7 +17,7 @@
// Find uses of OUString in conditional expressions that could be rewritten as std::u16string_view,
// as in
//
// s += (b ? OUString("xy") : OUString(z");
// s += (b ? OUString("xy") : OUString("z"));
namespace
{
@@ -215,9 +215,7 @@ public:
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_LessEqual)
.Namespace("rtl")
.GlobalNamespace()) //TODO: more precise check
if (dc.Operator(OO_LessEqual).Namespace("rtl").GlobalNamespace()) //TODO: more precise check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
connectivity/Module_connectivity.mk
-1
View File
@@ -22,7 +22,6 @@ $(eval $(call gb_Module_add_targets,connectivity,\
Configuration_flat \
Configuration_mysql_jdbc \
Configuration_odbc \
Configuration_mysql_jdbc \
Configuration_writer \
Library_calc \
Library_dbase \
connectivity/source/commontools/dbtools.cxx
+1 -1
View File
@@ -458,7 +458,7 @@ static SharedConnection lcl_connectRowSet(const Reference< XRowSet>& _rxRowSet,
}
catch(Exception&)
{
TOOLS_WARN_EXCEPTION( "connectivity.commontools", "EXception when we set the new active connection!");
TOOLS_WARN_EXCEPTION( "connectivity.commontools", "Exception when we set the new active connection!");
}
}
}
connectivity/source/drivers/dbase/DIndex.cxx
+1 -1
View File
@@ -554,7 +554,7 @@ void ODbaseIndex::CreateImpl()
if(xSet->last())
{
ODbaseResultSet* pDbaseRes = dynamic_cast<ODbaseResultSet*>(xSet.getTyped().get());
assert(pDbaseRes); //"No dbase resultset found? What's going on here!
assert(pDbaseRes); // No dbase resultset found? What's going on here!
nRowsLeft = xSet->getRow();
xSet->beforeFirst();
connectivity/source/drivers/dbase/DTable.cxx
+3 -3
View File
@@ -361,7 +361,7 @@ void ODbaseTable::fillColumns()
aTypeName = "NUMERIC";
eType = DataType::DECIMAL;
// for numeric fields two characters more are written, then the precision of the column description predescribes,
// for numeric fields two characters more are written, then the precision of the column description prescribes,
// to keep room for the possible sign and the comma. This has to be considered...
nPrecision = SvDbaseConverter::ConvertPrecisionToOdbc(nPrecision,aDBFColumn.db_dez);
// This is not true for older versions...
@@ -1651,7 +1651,7 @@ bool ODbaseTable::UpdateBuffer(OValueRefVector& rRow, const OValueRefRow& pOrgRo
::comphelper::UStringMixEqual aCase(isCaseSensitive());
Reference<XIndexAccess> xColumns(m_xColumns.get());
// first search a key that exist already in the table
// first search a key that exists already in the table
for (sal_Int32 i = 0; i < nColumnCount; ++i)
{
sal_Int32 nPos = i;
@@ -2519,7 +2519,7 @@ void ODbaseTable::copyData(ODbaseTable* _pNewTable,sal_Int32 _nPos)
{
OSL_ASSERT(false);
}
} // for(sal_uInt32 nRowPos = 0; nRowPos < m_aHeader.db_anz;++nRowPos)
} // for(sal_uInt32 nRowPos = 0; nRowPos < m_aHeader.nbRecords;++nRowPos)
}
void ODbaseTable::throwInvalidDbaseFormat()
connectivity/source/drivers/dbase/dindexnode.cxx
+1 -1
View File
@@ -169,7 +169,7 @@ sal_uInt16 ONDXPage::FindPos(const ONDXKey& rKey) const
bool ONDXPage::Find(const ONDXKey& rKey)
{
// searches the given key
// Speciality: At the end of the method
// Specialty: At the end of the method
// the actual page and the position of the node, fulfilling the '<=' condition, are saved
// This is considered at insert.
sal_uInt16 i = 0;
connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
+1 -1
View File
@@ -35,7 +35,7 @@ static void lcl_unescape(OUString& rName)
rName = rName.copy(1, rName.getLength() - 1);
}
// Replace double ` by simple `
// Replace double ` with single `
rName = rName.replaceAll("``", "`");
}
connectivity/source/inc/dbase/dindexnode.hxx
+1 -1
View File
@@ -75,7 +75,7 @@ namespace connectivity::dbase
class ONDXPage;
// Index Page Pointer
// This is ref-count pointer class
// This is a ref-counted pointer class
class ONDXPagePtr
{
friend SvStream& WriteONDXPagePtr(SvStream &rStream, const ONDXPagePtr&);
cui/source/factory/dlgfact.cxx
+3 -3
View File
@@ -242,7 +242,7 @@ VclPtr<SfxAbstractTabDialog> AbstractDialogFactory_Impl::CreateCustomizeTabDialo
return VclPtr<CuiAbstractTabController_Impl<SvxConfigDialog>>::Create(std::move(xDlg1));
}
// TabDialog that use functionality of the drawing layer
// TabDialog that uses functionality of the drawing layer
VclPtr<SfxAbstractTabDialog> AbstractDialogFactory_Impl::CreateTextTabDialog(weld::Window* pParent,
const SfxItemSet* pAttrSet,
SdrView* pView)
@@ -252,7 +252,7 @@ VclPtr<SfxAbstractTabDialog> AbstractDialogFactory_Impl::CreateTextTabDialog(wel
namespace
{
// AbstractSvxCaptionDialog implementations just forwards everything to the dialog
// AbstractSvxCaptionDialog implementation just forwards everything to the dialog
class AbstractSvxCaptionDialog_Impl final
: public vcl::AbstractDialogImpl_Async<AbstractSvxCaptionDialog, SvxCaptionTabDialog>
{
@@ -273,7 +273,7 @@ public:
};
}
// TabDialog that use functionality of the drawing layer and add AnchorTypes -- for SvxCaptionTabDialog
// TabDialog that uses functionality of the drawing layer and adds AnchorTypes -- for SvxCaptionTabDialog
VclPtr<AbstractSvxCaptionDialog> AbstractDialogFactory_Impl::CreateCaptionDialog(weld::Window* pParent,
const SdrView* pView,
SvxAnchorIds nAnchorTypes)
cui/source/factory/dlgfact.hxx
+1 -1
View File
@@ -20,7 +20,7 @@
#include <svx/svxdlg.hxx>
//AbstractDialogFactory_Impl implementations
// AbstractDialogFactory_Impl implementation
class AbstractDialogFactory_Impl : public SvxAbstractDialogFactory
{
public:
cui/source/inc/CommandCategoryListBox.hxx
+2 -2
View File
@@ -63,8 +63,8 @@ public:
}
/**
Signals that a command category has been selected.
And updates the functions list box to include
Signals that a command category has been selected,
and updates the functions list box to include
the commands in the selected category.
*/
void categorySelected(CuiConfigFunctionListBox* pFunctionListBox, const OUString& filterTerm,
cui/source/inc/cuitabarea.hxx
+1 -1
View File
@@ -714,7 +714,7 @@ private:
std::unique_ptr<weld::CustomWeld> m_xCtlPreviewOld;
std::unique_ptr<weld::CustomWeld> m_xCtlPreviewNew;
static void ConvertColorValues (Color& rColor, ColorModel eModell);
static void ConvertColorValues (Color& rColor, ColorModel eModel);
static void RgbToCmyk_Impl( Color& rColor, sal_uInt16& rK );
static void CmykToRgb_Impl( Color& rColor, const sal_uInt16 nKey );
sal_uInt16 ColorToPercent_Impl( sal_uInt16 nColor );
cui/uiconfig/ui/pageformatpage.ui
+1 -1
View File
@@ -54,7 +54,7 @@
<property name="can-focus">False</property>
<child internal-child="accessible">
<object class="AtkObject" id="comboPageFormat-atkobject">
<property name="AtkObject::accessible-description" translatable="yes" context="pageformatpage|extended-tip|comboPageFormat">Select a predefined paper size, or create a custom format by entering the dimensions for the paper in the Height and Width boxes.</property>
<property name="AtkObject::accessible-description" translatable="yes" context="pageformatpage|extended-tip|comboPageFormat">Select a predefined paper size, or create a custom format by entering the dimensions for the paper in the Height and Width boxes.</property>
</object>
</child>
</object>
desktop/qa/desktop_lib/test_desktop_lib.cxx
+4 -4
View File
@@ -2531,7 +2531,7 @@ void DesktopLOKTest::testCommentsWriter()
tools::Long nWidth, nHeight;
pDocument->m_pDocumentClass->getDocumentSize(pDocument, &nWidth, &nHeight);
// Document width alongwith without sidebar comes to be < 13000
// Document width without sidebar comes to be < 13000
CPPUNIT_ASSERT( nWidth < 13000 );
// Can we get all the comments using .uno:ViewAnnotations command ?
@@ -2680,7 +2680,7 @@ void DesktopLOKTest::testCommentsImpress()
void DesktopLOKTest::testCommentsCallbacksWriter()
{
// Comments callback are emitted only if tiled annotations are off
// Comment callbacks are emitted only if tiled annotations are off
comphelper::LibreOfficeKit::setTiledAnnotations(false);
LibLODocument_Impl* pDocument = loadDoc("comments.odt");
pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
@@ -2784,7 +2784,7 @@ void addParameter(tools::JsonWriter& rJson, const char* sName, std::string_view
void DesktopLOKTest::testCommentsAddEditDeleteDraw()
{
// Comments callback are emitted only if tiled annotations are off
// Comment callbacks are emitted only if tiled annotations are off
comphelper::LibreOfficeKit::setTiledAnnotations(false);
LibLODocument_Impl* pDocument = loadDoc("BlankDrawDocument.odg");
pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
@@ -3766,7 +3766,7 @@ void DesktopLOKTest::testABI()
CPPUNIT_ASSERT_EQUAL(classOffset(24), offsetof(LibreOfficeKitClass, getDocsCount));
CPPUNIT_ASSERT_EQUAL(classOffset(25), offsetof(LibreOfficeKitClass, registerFileSaveDialogCallback));
// When extending LibreOfficeKit with a new function pointer, add new assert for the offsetof the
// When extending LibreOfficeKit with a new function pointer, add new assert for the offsetof the
// new function pointer and bump this assert for the size of the class.
CPPUNIT_ASSERT_EQUAL(classOffset(26), sizeof(LibreOfficeKitClass));
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+2 -2
View File
@@ -647,7 +647,7 @@ VclMetafileProcessor2D::~VclMetafileProcessor2D()
XTEXT_EOW(i) end of word
XTEXT_EOS(i) end of sentence
this three are with index and are created with the help of an i18n::XBreakIterator in
these three are with index and are created with the help of an i18n::XBreakIterator in
ImplDrawWithComments. Simplifying, moving out text painting, reworking to create some
data structure for holding those TEXT infos.
Supported directly by TextSimplePortionPrimitive2D with adding a Locale to the basic text
@@ -2222,7 +2222,7 @@ void VclMetafileProcessor2D::processPolyPolygonGradientPrimitive2D(
// These will need more space and time, but the result will be as if the Gradient
// was rotated with the object.
// This mechanism is used by all exporters still not using Primitives (e.g. Print,
// Slideshow, Export rto PDF, export to Picture, ...) but relying on Metafile
// Slideshow, Export to PDF, export to Picture, ...) but relying on Metafile
// transfers. One more reason to *change* these to primitives.
// BTW: One more example how useful the principles of primitives are; the decomposition
// is by definition a simpler, maybe more expensive representation of the same content.
drawinglayer/source/tools/emfppath.cxx
+6 -6
View File
@@ -156,7 +156,7 @@ namespace emfplushelper
for (sal_uInt32 i = 0; i < nPoints; i++)
{
if (p && pPointTypes && (pPointTypes [i] == 0))
if (p && pPointTypes && (pPointTypes[i] == 0))
{
aPolygon.append (polygon);
last_normal = i;
@@ -165,15 +165,15 @@ namespace emfplushelper
}
if (bMapIt)
mapped = rR.Map(xPoints[i], yPoints [i]);
mapped = rR.Map(xPoints[i], yPoints[i]);
else
mapped = ::basegfx::B2DPoint(xPoints[i], yPoints[i]);
if (pPointTypes)
{
if ((pPointTypes [i] & 0x07) == 3)
if ((pPointTypes[i] & 0x07) == 3)
{
if (((i - last_normal )% 3) == 1)
if (((i - last_normal) % 3) == 1)
{
assert(p != 0);
polygon.setNextControlPoint (p - 1, mapped);
@@ -205,7 +205,7 @@ namespace emfplushelper
p++;
if (pPointTypes && (pPointTypes [i] & 0x80)) // closed polygon
if (pPointTypes && (pPointTypes[i] & 0x80)) // closed polygon
{
polygon.setClosed (true);
aPolygon.append (polygon);
@@ -339,6 +339,6 @@ namespace emfplushelper
aPolygon.append(polygon);
return aPolygon;
}
}
} // namespace emfplushelper
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
drawinglayer/source/tools/emfppath.hxx
+2 -2
View File
@@ -39,11 +39,11 @@ namespace emfplushelper
void Read(SvStream& s, sal_uInt32 pathFlags);
::basegfx::B2DPolyPolygon& GetPolygon(EmfPlusHelperData const & rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
::basegfx::B2DPolyPolygon& GetPolygon(EmfPlusHelperData const& rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
::basegfx::B2DPolyPolygon& GetCardinalSpline(EmfPlusHelperData const& rR, float fTension,
sal_uInt32 aOffset, sal_uInt32 aNumSegments);
::basegfx::B2DPolyPolygon& GetClosedCardinalSpline(EmfPlusHelperData const& rR, float fTension);
};
}
} // namespace emfplushelper
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
editeng/source/outliner/outliner.cxx
+1 -1
View File
@@ -1914,7 +1914,7 @@ std::optional<NonOverflowingText> Outliner::GetNonOverflowingText() const
if (nCount < 0)
{
SAL_INFO("editeng.chaining",
"[Overflowing] No Overflowing text but GetNonOverflowinText called?!");
"[Overflowing] No Overflowing text but GetNonOverflowingText called?!");
return {};
}
filter/qa/pdf.cxx
+1 -1
View File
@@ -463,7 +463,7 @@ CPPUNIT_TEST_FIXTURE(Test, testSignCertificatePEM)
std::unique_ptr<vcl::pdf::PDFiumDocument> pPdfDocument
= pPDFium->openDocument(aStream.GetData(), aStream.GetSize(), OString());
// Without the accompanying fix in place, this test would have failed, as signing was enabled
// without configured certificate, so the whole export failed.
// without configuring a certificate, so the whole export failed.
CPPUNIT_ASSERT(pPdfDocument);
CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getSignatureCount());
}