tdf#108831 PGP signature shown as invalid
It was valid, but not trusted. We need to show the owner trust in another place. gpg4libre Change-Id: I344a7b064a22c16b647c73d52f7abd91cfc86be9 Reviewed-on: https://gerrit.libreoffice.org/39826 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This commit is contained in:
committed by
Thorsten Behrens
parent
06929219ae
commit
bdbebda1d8
@@ -364,9 +364,7 @@ SAL_CALL XMLSignature_GpgImpl::validate(
|
||||
data_signature, data_text);
|
||||
|
||||
// TODO: needs some more error handling, needs checking _all_ signatures
|
||||
if( verify_res.isNull() ||
|
||||
verify_res.numSignatures() == 0 ||
|
||||
verify_res.signature(0).validity() < GpgME::Signature::Full )
|
||||
if( verify_res.isNull() || verify_res.numSignatures() == 0 )
|
||||
{
|
||||
// let's try again, but this time import the public key payload
|
||||
// (avoiding that in a first cut for being a bit speedier)
|
||||
@@ -415,9 +413,7 @@ SAL_CALL XMLSignature_GpgImpl::validate(
|
||||
verify_res=rCtx.verifyDetachedSignature(data_signature, data_text);
|
||||
|
||||
// TODO: needs some more error handling, needs checking _all_ signatures
|
||||
if( verify_res.isNull() ||
|
||||
verify_res.numSignatures() == 0 ||
|
||||
verify_res.signature(0).validity() < GpgME::Signature::Full )
|
||||
if( verify_res.isNull() || verify_res.numSignatures() == 0 )
|
||||
{
|
||||
clearErrorRecorder();
|
||||
xmlFree(pSignatureValue);
|
||||
|
||||
Reference in New Issue
Block a user