From 880b0b534cf5780dfe236def0847ded88da84019 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Wed, 3 Jul 2019 22:09:29 +0200 Subject: [PATCH] cid#1448214: perf inefficient map iterator Change-Id: Ia145b46400acf2b7a35bedf689fc7fe74758a2f3 Reviewed-on: https://gerrit.libreoffice.org/75060 Tested-by: Jenkins Reviewed-by: Julien Nabet --- .../star/lib/uno/helper/MultiTypeInterfaceContainer.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java b/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java index a255721046e5..803c02e8340c 100644 --- a/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java +++ b/javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java @@ -41,15 +41,14 @@ public class MultiTypeInterfaceContainer if ( (size=map.size()) > 0) { Type [] arTypes= new Type[size]; - Iterator it= map.keySet().iterator(); int countTypes= 0; - while (it.hasNext()) + for (Map.Entry entry : map.entrySet()) { - Object key= it.next(); - InterfaceContainer cont= map.get(key); + InterfaceContainer cont= entry.getValue(); if (cont != null && cont.size() > 0) { + Object key = entry.getKey(); if (key == null) arTypes[countTypes++]= new Type(); else if (key instanceof Type)