From 83abdf803a023067ebc207fd82dde987df233754 Mon Sep 17 00:00:00 2001 From: Gabor Kelemen Date: Mon, 29 Apr 2019 23:40:38 +0200 Subject: [PATCH] tdf#42949 Fix IWYU warnings in tools/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I47974f5c24819eb60e6724f42d51bb206dc26d21 Reviewed-on: https://gerrit.libreoffice.org/71557 Tested-by: Jenkins Reviewed-by: Miklos Vajna --- tools/IwyuFilter_tools.yaml | 34 +++++++++++++++++++ tools/inc/poly.h | 6 ---- tools/qa/cppunit/test_100mm2twips.cxx | 4 --- tools/qa/cppunit/test_bigint.cxx | 3 -- tools/qa/cppunit/test_color.cxx | 2 -- tools/qa/cppunit/test_fract.cxx | 1 - tools/qa/cppunit/test_fround.cxx | 1 - tools/qa/cppunit/test_inetmime.cxx | 2 -- tools/qa/cppunit/test_minmax.cxx | 1 - tools/qa/cppunit/test_pathutils.cxx | 2 -- tools/qa/cppunit/test_rectangle.cxx | 2 -- tools/qa/cppunit/test_stream.cxx | 1 - tools/qa/cppunit/test_xmlwalker.cxx | 5 --- tools/source/datetime/systemdatetime.cxx | 2 -- tools/source/datetime/ttime.cxx | 4 --- tools/source/debug/debug.cxx | 15 +------- tools/source/fsys/fileutil.cxx | 2 +- tools/source/fsys/urlobj.cxx | 2 -- tools/source/generic/bigint.cxx | 2 -- tools/source/generic/config.cxx | 5 --- tools/source/generic/fract.cxx | 3 -- tools/source/generic/line.cxx | 4 +-- tools/source/generic/point.cxx | 2 -- tools/source/generic/poly2.cxx | 2 -- tools/source/inet/inetmime.cxx | 2 -- tools/source/inet/inetmsg.cxx | 2 -- tools/source/inet/inetstrm.cxx | 1 - .../misc/extendapplicationenvironment.cxx | 7 ---- tools/source/stream/stream.cxx | 1 - tools/source/stream/strmunx.cxx | 5 --- tools/source/zcodec/zcodec.cxx | 1 - 31 files changed, 37 insertions(+), 89 deletions(-) create mode 100644 tools/IwyuFilter_tools.yaml diff --git a/tools/IwyuFilter_tools.yaml b/tools/IwyuFilter_tools.yaml new file mode 100644 index 000000000000..c24beaef25d9 --- /dev/null +++ b/tools/IwyuFilter_tools.yaml @@ -0,0 +1,34 @@ +--- +assumeFilename: tools/source/generic/gen.cxx +blacklist: + tools/qa/cppunit/test_pathutils.cxx: + # Needed for WIN32 specific unit test + - cppunit/TestAssert.h + - cppunit/plugin/TestPlugIn.h + - tools/pathutils.hxx + - cwchar + tools/source/debug/debug.cxx: + # Needed for linker visibility + - tools/diagnose_ex.h + tools/source/generic/poly.cxx: + # OSL_BIGENDIAN is being checked + - osl/endian.h + tools/source/misc/extendapplicationenvironment.cxx: + # Needed on MACOSX + - config_folders.h + # Needed for linker visibility + - tools/extendapplicationenvironment.hxx + tools/source/ref/ref.cxx: + # Don't replace with impl. detail + - tools/weakbase.hxx + tools/source/stream/strmwnt.cxx: + # WIN32-specific file + - string.h + - osl/thread.h + - o3tl/char16_t2wchar_t.hxx + tools/source/stream/strmunx.cxx: + # Needed for OSL_DEBUG_LEVEL > 1 + - osl/thread.h + tools/source/string/tenccvt.cxx: + # Needed for linker visibility + - tools/tenccvt.hxx diff --git a/tools/inc/poly.h b/tools/inc/poly.h index 2c84bf7459cf..17819ac93482 100644 --- a/tools/inc/poly.h +++ b/tools/inc/poly.h @@ -22,8 +22,6 @@ #include #include -class Point; - class SAL_WARN_UNUSED ImplPolygon { public: @@ -55,10 +53,6 @@ public: #define MAX_POLYGONS SAL_MAX_UINT16 -namespace tools { -class Polygon; -} - struct ImplPolyPolygon { std::vector mvPolyAry; diff --git a/tools/qa/cppunit/test_100mm2twips.cxx b/tools/qa/cppunit/test_100mm2twips.cxx index 93eab264f8da..80ceda2ffb3f 100644 --- a/tools/qa/cppunit/test_100mm2twips.cxx +++ b/tools/qa/cppunit/test_100mm2twips.cxx @@ -18,16 +18,12 @@ */ #include -#include #include #include -#include #include -#include - namespace tools { class cm2TwipsTest : public CppUnit::TestFixture diff --git a/tools/qa/cppunit/test_bigint.cxx b/tools/qa/cppunit/test_bigint.cxx index 9e02a609cce6..ef147961dbf4 100644 --- a/tools/qa/cppunit/test_bigint.cxx +++ b/tools/qa/cppunit/test_bigint.cxx @@ -17,12 +17,9 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include -#include - #include namespace tools diff --git a/tools/qa/cppunit/test_color.cxx b/tools/qa/cppunit/test_color.cxx index 011fbcbdfa65..9c2a4d9c7049 100644 --- a/tools/qa/cppunit/test_color.cxx +++ b/tools/qa/cppunit/test_color.cxx @@ -11,9 +11,7 @@ #include #include #include -#include #include -#include namespace { diff --git a/tools/qa/cppunit/test_fract.cxx b/tools/qa/cppunit/test_fract.cxx index 774427915392..897533d645fd 100644 --- a/tools/qa/cppunit/test_fract.cxx +++ b/tools/qa/cppunit/test_fract.cxx @@ -20,7 +20,6 @@ #include #include #include -#include #include #include diff --git a/tools/qa/cppunit/test_fround.cxx b/tools/qa/cppunit/test_fround.cxx index 8e7781363edf..4014ff3cb46b 100644 --- a/tools/qa/cppunit/test_fround.cxx +++ b/tools/qa/cppunit/test_fround.cxx @@ -20,7 +20,6 @@ #include #include #include -#include #include diff --git a/tools/qa/cppunit/test_inetmime.cxx b/tools/qa/cppunit/test_inetmime.cxx index cdeca0560276..12b1641890b4 100644 --- a/tools/qa/cppunit/test_inetmime.cxx +++ b/tools/qa/cppunit/test_inetmime.cxx @@ -17,12 +17,10 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include #include #include -#include #include diff --git a/tools/qa/cppunit/test_minmax.cxx b/tools/qa/cppunit/test_minmax.cxx index 390353045dfc..93709def974e 100644 --- a/tools/qa/cppunit/test_minmax.cxx +++ b/tools/qa/cppunit/test_minmax.cxx @@ -20,7 +20,6 @@ #include #include #include -#include #include diff --git a/tools/qa/cppunit/test_pathutils.cxx b/tools/qa/cppunit/test_pathutils.cxx index 9148a6ab340b..1b0c57c08afd 100644 --- a/tools/qa/cppunit/test_pathutils.cxx +++ b/tools/qa/cppunit/test_pathutils.cxx @@ -19,11 +19,9 @@ #include -#include #include #include #include -#include #include namespace { diff --git a/tools/qa/cppunit/test_rectangle.cxx b/tools/qa/cppunit/test_rectangle.cxx index c4b321d388eb..8b10ece6239b 100644 --- a/tools/qa/cppunit/test_rectangle.cxx +++ b/tools/qa/cppunit/test_rectangle.cxx @@ -7,11 +7,9 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include #include #include #include -#include #include namespace diff --git a/tools/qa/cppunit/test_stream.cxx b/tools/qa/cppunit/test_stream.cxx index cf164ee5a935..d8e4d1ef71e1 100644 --- a/tools/qa/cppunit/test_stream.cxx +++ b/tools/qa/cppunit/test_stream.cxx @@ -11,7 +11,6 @@ #include #include #include -#include #include #include diff --git a/tools/qa/cppunit/test_xmlwalker.cxx b/tools/qa/cppunit/test_xmlwalker.cxx index d10221937145..4c2f9a808ea6 100644 --- a/tools/qa/cppunit/test_xmlwalker.cxx +++ b/tools/qa/cppunit/test_xmlwalker.cxx @@ -7,11 +7,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include -#include - -#include -#include #include #include #include diff --git a/tools/source/datetime/systemdatetime.cxx b/tools/source/datetime/systemdatetime.cxx index cd07728ece98..2115f4b6205a 100644 --- a/tools/source/datetime/systemdatetime.cxx +++ b/tools/source/datetime/systemdatetime.cxx @@ -22,7 +22,6 @@ #endif #include #elif defined UNX -#include #include #endif @@ -33,7 +32,6 @@ #include #endif -#include #include #include diff --git a/tools/source/datetime/ttime.cxx b/tools/source/datetime/ttime.cxx index 068787dfe389..d99c337e9885 100644 --- a/tools/source/datetime/ttime.cxx +++ b/tools/source/datetime/ttime.cxx @@ -28,8 +28,6 @@ #include #include #elif defined UNX -#include -#include #include #endif @@ -40,10 +38,8 @@ #include #endif -#include #include #include -#include #include #include diff --git a/tools/source/debug/debug.cxx b/tools/source/debug/debug.cxx index efecd0f5027b..bfbb8e6b4554 100644 --- a/tools/source/debug/debug.cxx +++ b/tools/source/debug/debug.cxx @@ -17,17 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#if defined (UNX) || defined (__GNUC__) -#include -#endif - -#include -#include -#include -#include -#include -#include - #include #include #include @@ -37,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -57,13 +47,10 @@ #include #include #include -#include #include -#include #include #include -#include #include diff --git a/tools/source/fsys/fileutil.cxx b/tools/source/fsys/fileutil.cxx index e9efcb994e71..731afa58e63e 100644 --- a/tools/source/fsys/fileutil.cxx +++ b/tools/source/fsys/fileutil.cxx @@ -8,8 +8,8 @@ */ #include -#include #if defined _WIN32 +#include #include #include #include diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx index 91bdedf699ce..7ee92a3382b6 100644 --- a/tools/source/fsys/urlobj.cxx +++ b/tools/source/fsys/urlobj.cxx @@ -43,8 +43,6 @@ #include #include -#include -#include #include using namespace css; diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx index e80a513496c4..903cf826f44a 100644 --- a/tools/source/generic/bigint.cxx +++ b/tools/source/generic/bigint.cxx @@ -17,10 +17,8 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include -#include #include #include diff --git a/tools/source/generic/config.cxx b/tools/source/generic/config.cxx index 7c18f5390677..fe760decf852 100644 --- a/tools/source/generic/config.cxx +++ b/tools/source/generic/config.cxx @@ -19,8 +19,6 @@ #include #include -#include -#include #include #ifdef _WIN32 @@ -28,10 +26,7 @@ #endif #include -#include #include -#include -#include #include struct ImplKeyData diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx index 266b32fadf3e..e6e05dfd5dc6 100644 --- a/tools/source/generic/fract.cxx +++ b/tools/source/generic/fract.cxx @@ -19,14 +19,11 @@ #include #include -#include #include #include -#include #include #include -#include #include #include diff --git a/tools/source/generic/line.cxx b/tools/source/generic/line.cxx index b1a23635e9d6..26465c5c85d6 100644 --- a/tools/source/generic/line.cxx +++ b/tools/source/generic/line.cxx @@ -17,12 +17,10 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include -#include -#include +#include namespace tools { diff --git a/tools/source/generic/point.cxx b/tools/source/generic/point.cxx index 1b470c6065ec..f33fe9a28803 100644 --- a/tools/source/generic/point.cxx +++ b/tools/source/generic/point.cxx @@ -17,8 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include - #include #include diff --git a/tools/source/generic/poly2.cxx b/tools/source/generic/poly2.cxx index 82b996ed68db..0603a1dc8513 100644 --- a/tools/source/generic/poly2.cxx +++ b/tools/source/generic/poly2.cxx @@ -17,7 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include #include @@ -27,7 +26,6 @@ #include #include #include -#include #include namespace tools { diff --git a/tools/source/inet/inetmime.cxx b/tools/source/inet/inetmime.cxx index decd1041a547..14ad5b9d1485 100644 --- a/tools/source/inet/inetmime.cxx +++ b/tools/source/inet/inetmime.cxx @@ -18,12 +18,10 @@ */ #include -#include #include #include #include -#include #include #include #include diff --git a/tools/source/inet/inetmsg.cxx b/tools/source/inet/inetmsg.cxx index 3a3a9c297ed9..e393baaaf91e 100644 --- a/tools/source/inet/inetmsg.cxx +++ b/tools/source/inet/inetmsg.cxx @@ -20,8 +20,6 @@ #include #include #include -#include -#include #include #include diff --git a/tools/source/inet/inetstrm.cxx b/tools/source/inet/inetstrm.cxx index 34cb3736bd07..c23289923af4 100644 --- a/tools/source/inet/inetstrm.cxx +++ b/tools/source/inet/inetstrm.cxx @@ -21,7 +21,6 @@ #include -#include #include #include #include diff --git a/tools/source/misc/extendapplicationenvironment.cxx b/tools/source/misc/extendapplicationenvironment.cxx index a2ae45720ed1..64e1d9801a79 100644 --- a/tools/source/misc/extendapplicationenvironment.cxx +++ b/tools/source/misc/extendapplicationenvironment.cxx @@ -17,7 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include @@ -26,17 +25,11 @@ #if defined UNX #include -#include -#include #endif #include -#include #include -#include -#include #include -#include #include #include #include diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx index 7eaef59e5883..453073c61112 100644 --- a/tools/source/stream/stream.cxx +++ b/tools/source/stream/stream.cxx @@ -24,7 +24,6 @@ #include #include -#include #include #include diff --git a/tools/source/stream/strmunx.cxx b/tools/source/stream/strmunx.cxx index c682071a112c..4ba6da6dfe1b 100644 --- a/tools/source/stream/strmunx.cxx +++ b/tools/source/stream/strmunx.cxx @@ -19,12 +19,8 @@ #include #include -#include -#include #include #include -#include -#include #include #include @@ -37,7 +33,6 @@ #include #include #include -#include using namespace osl; diff --git a/tools/source/zcodec/zcodec.cxx b/tools/source/zcodec/zcodec.cxx index 70cfd8aac0d5..ae1bc812c626 100644 --- a/tools/source/zcodec/zcodec.cxx +++ b/tools/source/zcodec/zcodec.cxx @@ -27,7 +27,6 @@ #include #include -#include #define PZSTREAM static_cast(mpsC_Stream)