From 7774e0bb716d6f60e32f259d49d2e07e5b0de792 Mon Sep 17 00:00:00 2001 From: Khaled Hosny Date: Sun, 16 Jul 2023 07:30:02 +0300 Subject: [PATCH] Make CppunitTest_svgio CPPUNIT_TEST_NAME=testCssClassRedefinition more robust MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The commit: commit 9e83d35c4a22bcb465f0736dda9b752b29f83959 Date: Thu Jun 23 21:52:52 2022 +0200 Make CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust Changed the font from generic Sans to Open Symbol to avoid failure when a different font is used, but it didn’t change the text string to a one supported by Open Symbol, so font fallback would still make the test fail. Change the text string to “012” which is supported by Open Symbol. Change-Id: I6e6ba22614ef1bafe5aece05c42d57d71923380c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154492 Tested-by: Jenkins Reviewed-by: خالد حسني --- svgio/qa/cppunit/SvgImportTest.cxx | 2 +- svgio/qa/cppunit/data/CssClassRedefinition.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/svgio/qa/cppunit/SvgImportTest.cxx b/svgio/qa/cppunit/SvgImportTest.cxx index 0a976eb276e0..5845b7ea6f52 100644 --- a/svgio/qa/cppunit/SvgImportTest.cxx +++ b/svgio/qa/cppunit/SvgImportTest.cxx @@ -1512,7 +1512,7 @@ CPPUNIT_TEST_FIXTURE(Test, testCssClassRedefinition) drawinglayer::Primitive2dXmlDump dumper; xmlDocUniquePtr pDocument = dumper.dumpAndParse(Primitive2DContainer(aSequence)); CPPUNIT_ASSERT (pDocument); - assertXPath(pDocument, "/primitive2D/transform/textsimpleportion[1]", "text", "test"); + assertXPath(pDocument, "/primitive2D/transform/textsimpleportion[1]", "text", "012"); assertXPath(pDocument, "/primitive2D/transform/textsimpleportion[1]", "fontcolor", "#ff0000"); assertXPath( pDocument, "/primitive2D/transform/textsimpleportion[1]", "familyname", "Open Symbol"); diff --git a/svgio/qa/cppunit/data/CssClassRedefinition.svg b/svgio/qa/cppunit/data/CssClassRedefinition.svg index 384cf88482f9..591f07f8b42d 100644 --- a/svgio/qa/cppunit/data/CssClassRedefinition.svg +++ b/svgio/qa/cppunit/data/CssClassRedefinition.svg @@ -8,6 +8,6 @@ - test + 012