ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#173578 Reduce spacing between ColorIconView items

Browse Source 
With the switch from the custom SvxColorValueSet
to the weld::IconView based ColorIconView in

    commit 701cea2393
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Apr 17 09:45:29 2026 +0200

        tdf#130857 Introduce ColorIconView, port "Area" page's "Color" section to it

and

    commit a4d5983b4e
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Jun 5 11:48:54 2026 +0200

        tdf#130857 Port ColorWindow from SvxColorValueSet to ColorIconView

and

    commit 9ed6b0a88f
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon Jun 8 14:00:33 2026 +0200

        Use ColorIconView for SvxDefaultColorOptPage

and

    commit dc3b6ec185
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Wed Jun 10 10:25:27 2026 +0200

        tdf#130857 sc: Port tab color dialog to ColorIconView

, spacing between the color items was implicitly
switched to the default values for the IconView
implementations, which is quite a bit more than
it was before at least for the GTK and vcl
implementations.

As requested in tdf#173578, reduce the spacing
again.

Now that weld::IconView is used, use the corresponding
GtkIconView spacing properties that can be set in
the .ui file.

For the GTK implementation (GtkInstanceIconView),
these are applied "automatically" because
GTK handles them internally.

For the vcl and Qt implementations (SalInstanceIconView
and QtInstanceIconView), they are not yet applied because
these properties are not evaluated yet.

For the vcl implementation, evaluating
GtkIconView::item-padding [1] will be added in
an upcoming commit.

For the Qt implementation, the spacing looks quite OK
to me (at least with the Fusion style on Linux).
Evaluating that property could still be added later as
needed. QListView::spacing [2] looks related.

[1] https://docs.gtk.org/gtk3/property.IconView.item-padding.html
[2] https://doc.qt.io/qt-6/qlistview.html#spacing-prop

Change-Id: I703504b7e2ce0c4b5351a95616112950a33332dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211358
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit is contained in:
Michael Weghorn
2026-09-23 14:18:36 +02:00
parent 5d6c85d78b
commit 653c741ebc
3 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cui/uiconfig/ui/colorpage.ui
+6
View File
@@ -167,7 +167,10 @@
<property name="model">coloriconviewmodel</property>
<property name="columns">12</property>
<property name="pixbuf-column">0</property>
<property name="row-spacing">0</property>
<property name="column-spacing">0</property>
<property name="tooltip-column">2</property>
<property name="item-padding">2</property>
<property name="activate-on-single-click">True</property>
</object>
</child>
@@ -214,7 +217,10 @@
<property name="model">recentcoloriconviewmodel</property>
<property name="columns">12</property>
<property name="pixbuf-column">0</property>
<property name="row-spacing">0</property>
<property name="column-spacing">0</property>
<property name="tooltip-column">2</property>
<property name="item-padding">2</property>
<property name="activate-on-single-click">True</property>
</object>
<packing>
cui/uiconfig/ui/optchartcolorspage.ui
+3
View File
@@ -210,7 +210,10 @@
<property name="model">tableiconview_model</property>
<property name="columns">12</property>
<property name="pixbuf-column">0</property>
<property name="row-spacing">0</property>
<property name="column-spacing">0</property>
<property name="tooltip-column">2</property>
<property name="item-padding">2</property>
<property name="activate-on-single-click">True</property>
</object>
</child>