From 5c4e96b466e8dc1903d5b24762e8117269e64da7 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Sat, 29 Dec 2018 10:56:28 +0100 Subject: [PATCH] Initialize DragSource::mDragSourceHelper At least during CppunitTest_basctl_dialogs_test, DragSource::initialize apparently throws an exception before initializing mDragSourceHelper, so that [mDragSourceHelper release]; in ~DragSource may cause a crash. Change-Id: Ic11b5d7a1dbfd5636d6f25b30b509d0d8a381262 Reviewed-on: https://gerrit.libreoffice.org/65702 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- vcl/osx/DragSource.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/vcl/osx/DragSource.cxx b/vcl/osx/DragSource.cxx index 11ba53d9ee6c..6203152829eb 100644 --- a/vcl/osx/DragSource.cxx +++ b/vcl/osx/DragSource.cxx @@ -146,6 +146,7 @@ DragSource::DragSource(): mView(nullptr), mpFrame(nullptr), mLastMouseEventBeforeStartDrag(nil), + mDragSourceHelper(nil), m_MouseButton(0) { }