From 39f331e50bc1349071348dca944c14398d2c7aa9 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 26 Jan 2026 09:37:31 +0200 Subject: [PATCH] cid#1680643 Logically dead code regression from commit bd047bbb9e43e0a4432e8e84408c2117a7ffe7a3 Author: Armin Le Grand (collabora) Date: Tue Jan 20 16:18:20 2026 +0100 SmartArt: Preparations for roundtrip Change-Id: I65a5bec1c448f10644e4435b13241eaccc58ce22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198120 Tested-by: Jenkins Reviewed-by: Noel Grandin --- svx/source/diagram/IDiagramHelper.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/svx/source/diagram/IDiagramHelper.cxx b/svx/source/diagram/IDiagramHelper.cxx index 903d3b50e0da..7472d7747a47 100644 --- a/svx/source/diagram/IDiagramHelper.cxx +++ b/svx/source/diagram/IDiagramHelper.cxx @@ -429,7 +429,7 @@ void IDiagramHelper::disconnectFromSdrObjGroup() void IDiagramHelper::connectToSdrObjGroup(com::sun::star::uno::Reference< com::sun::star::drawing::XShape >& rTarget) { SdrObjGroup* pGroupObject(nullptr); - if (pGroupObject && mxGroupShape && rTarget == mxGroupShape) + if (mxGroupShape && rTarget == mxGroupShape) { pGroupObject = dynamic_cast(SdrObject::getSdrObjectFromXShape(mxGroupShape)); if (pGroupObject != nullptr && pGroupObject->mp_DiagramHelper.get() == this)