From 379fe0409e7973b36210cffa3dd1dfd4032f0ecc Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 17 Nov 2015 10:49:32 +0100 Subject: [PATCH] Assume that this code wants to append a number, not a character The original code in 2638faa2e834c2da4c195224fd88d32c29b3d0cc "writerfilter08ooo330: applied patch for writerfilter08" used OUString::valueOf, which 64b993e046f23baaacaff1572b7d2a816588b5ef "finish deprecation of O(U)String::valueOf()" changed to a OUString ctor instead of OUString::number (as that change did for almost all other cases), but without giving a rationale for this particular case. But as nUnique starts out as zero, so in the first round would append a NUL character to "DOCX-Standard", it looks plausible that this code should add a number after all. Change-Id: I47136486e28b946fa334a416d1d2fe20ad616ff0 --- writerfilter/source/dmapper/FormControlHelper.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/writerfilter/source/dmapper/FormControlHelper.cxx b/writerfilter/source/dmapper/FormControlHelper.cxx index c35edcfce1f1..abcdc9f680c0 100644 --- a/writerfilter/source/dmapper/FormControlHelper.cxx +++ b/writerfilter/source/dmapper/FormControlHelper.cxx @@ -98,7 +98,7 @@ uno::Reference FormControlHelper::FormControlHelper_Impl::getForm() { ++nUnique; sFormName = sDOCXForm; - sFormName += OUString(nUnique); + sFormName += OUString::number(nUnique); } uno::Reference xForm(getServiceFactory()->createInstance("com.sun.star.form.component.Form"));