ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

crashtesting: ClickAction_VANISH missing from translations

Browse Source 
seen on converting ooo103896-3.odp to pdf

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5fb08b84fd0b84f704421e0af9a47a8ef34af957
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/7232
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
(cherry picked from commit 7b41c8b3f607ff8e6bd3a0d6ec23ff481921b9aa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208280
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit is contained in:
Caolán McNamara
2026-10-05 20:33:14 +02:00
committed by Xisco Fauli
parent 14d535067a
commit 3130f90ac9
2 changed files with 30 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sd/inc/strings.hrc
+2
View File
@@ -144,6 +144,8 @@
#define STR_GOTO_SLIDE_DLG_TITLE NC_("STR_GOTO_SLIDE_DLG_TITLE", "Go to Slide") #define STR_GOTO_SLIDE_DLG_TITLE NC_("STR_GOTO_SLIDE_DLG_TITLE", "Go to Slide")
#define STR_CLICK_ACTION_BOOKMARK NC_("STR_CLICK_ACTION_BOOKMARK", "Go to page or object") #define STR_CLICK_ACTION_BOOKMARK NC_("STR_CLICK_ACTION_BOOKMARK", "Go to page or object")
#define STR_CLICK_ACTION_DOCUMENT NC_("STR_CLICK_ACTION_DOCUMENT", "Go to document") #define STR_CLICK_ACTION_DOCUMENT NC_("STR_CLICK_ACTION_DOCUMENT", "Go to document")
#define STR_CLICK_ACTION_INVISIBLE NC_("STR_CLICK_ACTION_INVISIBLE", "Hide object")
#define STR_CLICK_ACTION_VANISH NC_("STR_CLICK_ACTION_VANISH", "Hide object with effect")
#define STR_CLICK_ACTION_SOUND NC_("STR_CLICK_ACTION_SOUND", "Play audio") #define STR_CLICK_ACTION_SOUND NC_("STR_CLICK_ACTION_SOUND", "Play audio")
#define STR_CLICK_ACTION_VERB NC_("STR_CLICK_ACTION_VERB", "Start object action") #define STR_CLICK_ACTION_VERB NC_("STR_CLICK_ACTION_VERB", "Start object action")
#define STR_CLICK_ACTION_PROGRAM NC_("STR_CLICK_ACTION_PROGRAM", "Run program") #define STR_CLICK_ACTION_PROGRAM NC_("STR_CLICK_ACTION_PROGRAM", "Run program")
sd/source/ui/unoidl/unomodel.cxx
+28 -17
View File
@@ -197,6 +197,8 @@ using namespace ::cppu;
using namespace ::com::sun::star; using namespace ::com::sun::star;
using namespace ::sd; using namespace ::sd;
namespace
{
const TranslateId aTypeResIds[SdLinkTargetType::Count] = const TranslateId aTypeResIds[SdLinkTargetType::Count] =
{ {
STR_SD_PAGE, // SdLinkTargetType::Page STR_SD_PAGE, // SdLinkTargetType::Page
@@ -205,25 +207,34 @@ const TranslateId aTypeResIds[SdLinkTargetType::Count] =
STR_MASTERPAGE_NAME, // SdLinkTargetType::MasterPage STR_MASTERPAGE_NAME, // SdLinkTargetType::MasterPage
}; };
const TranslateId aClickActionResIds[] =
{
STR_CLICK_ACTION_NONE, // ClickAction_NONE
STR_CLICK_ACTION_PREVPAGE, // ClickAction_PREVPAGE
STR_CLICK_ACTION_NEXTPAGE, // ClickAction_NEXTPAGE
STR_CLICK_ACTION_FIRSTPAGE, // ClickAction_FIRSTPAGE
STR_CLICK_ACTION_LASTPAGE, // ClickAction_LASTPAGE
STR_CLICK_ACTION_BOOKMARK, // ClickAction_BOOKMARK
STR_CLICK_ACTION_DOCUMENT, // ClickAction_DOCUMENT
STR_CLICK_ACTION_INVISIBLE, // ClickAction_INVISIBLE
STR_CLICK_ACTION_SOUND, // ClickAction_SOUND
STR_CLICK_ACTION_VERB, // ClickAction_VERB
STR_CLICK_ACTION_VANISH, // ClickAction_VANISH
STR_CLICK_ACTION_PROGRAM, // ClickAction_PROGRAM
STR_CLICK_ACTION_MACRO, // ClickAction_MACRO
STR_CLICK_ACTION_STOPPRESENTATION, // ClickAction_STOPPRESENTATION
};
static_assert(SAL_N_ELEMENTS(aClickActionResIds)
== static_cast<size_t>(presentation::ClickAction_STOPPRESENTATION) + 1,
"aClickActionResIds is missing an entry for a presentation::ClickAction value");
}
TranslateId SdTPAction::GetClickActionSdResId( presentation::ClickAction eCA ) TranslateId SdTPAction::GetClickActionSdResId( presentation::ClickAction eCA )
{ {
switch( eCA ) auto nIndex = static_cast<size_t>(eCA);
{ assert(nIndex < SAL_N_ELEMENTS(aClickActionResIds) && "ClickAction out of range");
case presentation::ClickAction_NONE: return STR_CLICK_ACTION_NONE; return aClickActionResIds[nIndex];
case presentation::ClickAction_PREVPAGE: return STR_CLICK_ACTION_PREVPAGE;
case presentation::ClickAction_NEXTPAGE: return STR_CLICK_ACTION_NEXTPAGE;
case presentation::ClickAction_FIRSTPAGE: return STR_CLICK_ACTION_FIRSTPAGE;
case presentation::ClickAction_LASTPAGE: return STR_CLICK_ACTION_LASTPAGE;
case presentation::ClickAction_BOOKMARK: return STR_CLICK_ACTION_BOOKMARK;
case presentation::ClickAction_DOCUMENT: return STR_CLICK_ACTION_DOCUMENT;
case presentation::ClickAction_PROGRAM: return STR_CLICK_ACTION_PROGRAM;
case presentation::ClickAction_MACRO: return STR_CLICK_ACTION_MACRO;
case presentation::ClickAction_SOUND: return STR_CLICK_ACTION_SOUND;
case presentation::ClickAction_VERB: return STR_CLICK_ACTION_VERB;
case presentation::ClickAction_STOPPRESENTATION: return STR_CLICK_ACTION_STOPPRESENTATION;
default: OSL_FAIL( "No StringResource for ClickAction available!" );
}
return {};
} }
class SdUnoForbiddenCharsTable : public SvxUnoForbiddenCharsTable, class SdUnoForbiddenCharsTable : public SvxUnoForbiddenCharsTable,