From 25552416c07a0841c32d71663cf2df75cbd174ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Mon, 26 Aug 2024 21:02:36 +0100 Subject: [PATCH] cid#1606904 silence Overflowed constant MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit and cid#1606871 silence Overflowed constant Change-Id: Ibfa7b63bf6879b24dc28df9d889c6692ec5a4e23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172512 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- dbaccess/source/ui/browser/sbagrid.cxx | 2 +- sw/source/uibase/uno/unotxdoc.cxx | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dbaccess/source/ui/browser/sbagrid.cxx b/dbaccess/source/ui/browser/sbagrid.cxx index 31bcf1ebfa6a..2657c9e741ff 100644 --- a/dbaccess/source/ui/browser/sbagrid.cxx +++ b/dbaccess/source/ui/browser/sbagrid.cxx @@ -924,7 +924,7 @@ void SbaGridControl::StartDrag( sal_Int8 _nAction, const Point& _rPosPixel ) // my laziness says 'do it here'...) sal_Int32 nRow = GetRowAtYPosPixel(_rPosPixel.Y()); sal_uInt16 nColPos = GetColumnAtXPosPixel(_rPosPixel.X()); - sal_uInt16 nViewPos = (nColPos == BROWSER_INVALIDID) ? sal_uInt16(-1) : nColPos-1; + sal_uInt16 nViewPos = (nColPos == BROWSER_INVALIDID) ? sal_uInt16(-1) : sal_uInt16(nColPos-1); // 'the handle column' and 'no valid column' will both result in a view position of -1 ! bool bCurrentRowVirtual = IsCurrentAppending() && IsModified(); diff --git a/sw/source/uibase/uno/unotxdoc.cxx b/sw/source/uibase/uno/unotxdoc.cxx index 6262416a480f..c76a313cc8ae 100644 --- a/sw/source/uibase/uno/unotxdoc.cxx +++ b/sw/source/uibase/uno/unotxdoc.cxx @@ -235,8 +235,9 @@ static std::unique_ptr lcl_GetPrintUIOptions( { sal_uInt16 nMax = nCurrentPage; const SwPageFrame *pPage = dynamic_cast(pFrame->Lower()); - while (pPage && nMax-- > 0) + while (pPage && nMax > 0) { + nMax--; if (pPage->getFrameArea().Height() == 0) nCurrentPage--; pPage = static_cast(pPage->GetNext());