From 1e6cc2c8564e86465594f6651490f529dafb3aaf Mon Sep 17 00:00:00 2001 From: Takeshi Abe Date: Sun, 2 Dec 2018 16:47:40 +0900 Subject: [PATCH] sc: Drop ineffective SetError() as GetNewMat() already sets error FormulaError::MatrixSize when returning null. In fact IllegalArgument is irrelevant here. Change-Id: Ib7354c2e861b666deef1353b2c26d876668d77e3 Reviewed-on: https://gerrit.libreoffice.org/64420 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/source/core/tool/interpr5.cxx | 3 --- 1 file changed, 3 deletions(-) diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx index db6500b067f1..a8197718fe77 100644 --- a/sc/source/core/tool/interpr5.cxx +++ b/sc/source/core/tool/interpr5.cxx @@ -438,10 +438,7 @@ ScMatrixRef ScInterpreter::GetMatrix() PopExternalSingleRef(pToken); pMat = GetNewMat( 1, 1, true); if (!pMat) - { - SetError( FormulaError::IllegalArgument); break; - } if (nGlobalError != FormulaError::NONE) { pMat->PutError( nGlobalError, 0, 0);