From 0ef39cbc0b2ff1fae29831e11a564776e0ed7cd5 Mon Sep 17 00:00:00 2001 From: Neil Roberts Date: Mon, 5 Oct 2026 15:40:54 +0200 Subject: [PATCH] store: Use rtl::Reference::get() instead of &* MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using &* can be problematic if the pointer is null. In this case it doesn’t matter, but using Reference::get() is probably easier to understand anyway. This also paves the way for a later compiler plugin to check for this. Change-Id: I52837f7c972a87229ecbc4f72ee4c2f352a04dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211840 Reviewed-by: Neil Roberts Tested-by: Jenkins --- store/source/store.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/store/source/store.cxx b/store/source/store.cxx index 24439a4e2a81..8bf5de2a875f 100644 --- a/store/source/store.cxx +++ b/store/source/store.cxx @@ -105,7 +105,7 @@ storeError store_createMemoryFile ( Reference xManager (new OStorePageManager()); eErrCode = xManager->initialize ( - &*xLockBytes, storeAccessMode::Create, nPageSize); + xLockBytes.get(), storeAccessMode::Create, nPageSize); if (eErrCode != store_E_None) return eErrCode; @@ -137,7 +137,7 @@ storeError store_openFile ( Reference xManager (new OStorePageManager()); eErrCode = xManager->initialize ( - &*xLockBytes, eAccessMode, nPageSize); + xLockBytes.get(), eAccessMode, nPageSize); if (eErrCode != store_E_None) return eErrCode; @@ -201,7 +201,7 @@ storeError store_openDirectory ( OString aPath (pPath->buffer, pPath->length, RTL_TEXTENCODING_UTF8); OString aName (pName->buffer, pName->length, RTL_TEXTENCODING_UTF8); - eErrCode = xDirectory->create (&*xManager, aPath.pData, aName.pData, eAccessMode); + eErrCode = xDirectory->create (xManager.get(), aPath.pData, aName.pData, eAccessMode); if (eErrCode != store_E_None) return eErrCode; @@ -279,7 +279,7 @@ storeError store_openStream ( OString aPath (pPath->buffer, pPath->length, RTL_TEXTENCODING_UTF8); OString aName (pName->buffer, pName->length, RTL_TEXTENCODING_UTF8); - eErrCode = xLockBytes->create (&*xManager, aPath.pData, aName.pData, eAccessMode); + eErrCode = xLockBytes->create (xManager.get(), aPath.pData, aName.pData, eAccessMode); if (eErrCode != store_E_None) return eErrCode;