sd: Drop always false TableDesignWidget::m_bModal

The member is initialized to false in the ctor
and that value is never changed afterwards.
Drop it altogether and simplify code accordingly.

Change-Id: I0213e9f74b353a214af3ad163a934bfa7e868412
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211913
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins

sd/source/ui/inc/TableDesignPane.hxx

@@ -54,7 +54,6 @@ enum TableCheckBox : sal_uInt16
 class TableValueSet final : public ValueSet
 {
 private:
-    bool m_bModal;
     Link<const Point*, void> maContextMenuHandler;
 public:
     TableValueSet(std::unique_ptr<weld::ScrolledWindow> pScrolledWindow);

sd/source/ui/table/TableDesignPane.cxx

@@ -621,8 +621,6 @@ void TableValueSet::Resize()
     SetColCount (static_cast<sal_uInt16>(nColumnCount));
     SetLineCount (static_cast<sal_uInt16>(nVisibleRowCount));
 
-    if( !m_bModal )
-    {
     WinBits nStyle = GetStyle() & ~WB_VSCROLL;
     if (nRowCount > nVisibleRowCount)
     {
@@ -630,11 +628,9 @@ void TableValueSet::Resize()
     }
     SetStyle(nStyle);
 }
-}
 
 TableValueSet::TableValueSet(std::unique_ptr<weld::ScrolledWindow> pScrolledWindow)
     : ValueSet(std::move(pScrolledWindow))
-    , m_bModal(false)
 {
 }
 
@@ -644,14 +640,11 @@ void TableValueSet::StyleUpdated()
 }
 
 void TableValueSet::updateSettings()
-{
-    if( !m_bModal )
 {
     Color aColor = Application::GetSettings().GetStyleSettings().GetWindowColor();
     SetColor(aColor);
     SetExtraSpacing(8);
 }
-}
 
 void TableDesignWidget::updateControls()
 {