From 02692566ad9fc7c3484f8581ffa0004cd4e43987 Mon Sep 17 00:00:00 2001
From: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu, 24 Oct 2024 17:43:35 +0200
Subject: [PATCH] tdf#130857 optnewdictionarydialog.ui: Define focusable
 widgets in order

Switch the order that the widgets are defined in the .ui file
to match their logical order (to be top to bottom, left to right)
as also described by their "left-attach" and "top-attach"
properties.

This only rearranges the order without changing anything else
for the single children and doesn't have any effect for the gtk3
and VCL implementations.

But as described in more details in

    commit 0fe7b3cebc1a070b13b825635f4bd387a22e41ab
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Wed Oct 23 22:43:10 2024 +0200

        tdf#130857 printersetupdialog.ui: Define focusable widgets in order

, Qt uses the construction order of widgets to determine
the tab order as well, meaning that focus would unexpectedly jump from
the edit to the checkbox, then back to the combobox without
this commit in place for the qt5 and qt6 VCL plugins in this
dialog ("Tools" -> "Options" -> "Languages and Locales" -> "Writing Aids"
-> "New") now that native Qt widgets are used.

Change-Id: Ib09137cb11dab60c4a1af4fbc3b007e801dea33b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175567
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
---
 cui/uiconfig/ui/optnewdictionarydialog.ui | 68 +++++++++++------------
 1 file changed, 34 insertions(+), 34 deletions(-)

diff --git a/cui/uiconfig/ui/optnewdictionarydialog.ui b/cui/uiconfig/ui/optnewdictionarydialog.ui
index 0566ea9d638d..8f97fa73a2f3 100644
--- a/cui/uiconfig/ui/optnewdictionarydialog.ui
+++ b/cui/uiconfig/ui/optnewdictionarydialog.ui
@@ -89,6 +89,20 @@
                 <property name="column_spacing">12</property>
                 <property name="margin-start">12</property>
                 <property name="margin-top">6</property>
+                <child>
+                  <object class="GtkLabel" id="name_label">
+                    <property name="visible">True</property>
+                    <property name="can_focus">False</property>
+                    <property name="label" translatable="yes" context="optnewdictionarydialog|name_label">_Name:</property>
+                    <property name="use_underline">True</property>
+                    <property name="mnemonic_widget">nameedit</property>
+                    <property name="xalign">0</property>
+                  </object>
+                  <packing>
+                    <property name="left_attach">0</property>
+                    <property name="top_attach">0</property>
+                  </packing>
+                </child>
                 <child>
                   <object class="GtkEntry" id="nameedit">
                     <property name="visible">True</property>
@@ -108,20 +122,6 @@
                     <property name="top_attach">0</property>
                   </packing>
                 </child>
-                <child>
-                  <object class="GtkLabel" id="name_label">
-                    <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="label" translatable="yes" context="optnewdictionarydialog|name_label">_Name:</property>
-                    <property name="use_underline">True</property>
-                    <property name="mnemonic_widget">nameedit</property>
-                    <property name="xalign">0</property>
-                  </object>
-                  <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">0</property>
-                  </packing>
-                </child>
                 <child>
                   <object class="GtkLabel" id="language_label">
                     <property name="visible">True</property>
@@ -136,26 +136,6 @@
                     <property name="top_attach">1</property>
                   </packing>
                 </child>
-                <child>
-                  <object class="GtkCheckButton" id="except">
-                    <property name="label" translatable="yes" context="optnewdictionarydialog|except">_Exception (-)</property>
-                    <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">False</property>
-                    <property name="use_underline">True</property>
-                    <property name="draw_indicator">True</property>
-                    <child internal-child="accessible">
-                      <object class="AtkObject" id="except-atkobject">
-                        <property name="AtkObject::accessible-description" translatable="yes" context="except">Specifies whether you wish to avoid certain words in your documents.</property>
-                      </object>
-                    </child>
-                  </object>
-                  <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">2</property>
-                    <property name="width">2</property>
-                  </packing>
-                </child>
                 <child>
                   <object class="GtkComboBoxText" id="language">
                     <property name="visible">True</property>
@@ -179,6 +159,26 @@
                     <property name="top_attach">1</property>
                   </packing>
                 </child>
+                <child>
+                  <object class="GtkCheckButton" id="except">
+                    <property name="label" translatable="yes" context="optnewdictionarydialog|except">_Exception (-)</property>
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="receives_default">False</property>
+                    <property name="use_underline">True</property>
+                    <property name="draw_indicator">True</property>
+                    <child internal-child="accessible">
+                      <object class="AtkObject" id="except-atkobject">
+                        <property name="AtkObject::accessible-description" translatable="yes" context="except">Specifies whether you wish to avoid certain words in your documents.</property>
+                      </object>
+                    </child>
+                  </object>
+                  <packing>
+                    <property name="left_attach">0</property>
+                    <property name="top_attach">2</property>
+                    <property name="width">2</property>
+                  </packing>
+                </child>
               </object>
             </child>
             <child type="label">